Migrate from WatchKit storyboard to SwiftUI and its lifecycle #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Bert <[email protected]>
saveTrustedCertificate() writes with PropertyListEncoder instead of NSKeyedArchiver loadTrustedCertificates() attempts first decoding with PropertyListDecoder() if error is thrown it unarchives with NSKeyedUnarchiver() Signed-off-by: Tim Bert <[email protected]>
Signed-off-by: Dan Cunningham <[email protected]> Signed-off-by: Tim Bert <[email protected]>
…ge from closure to function (in the past this allowed reuse code for challenge responses between Kingfisher and Alamofire libraries), simplified their signature as the first two parameters were ignored, avoids useless initializers for URLSession and URLSessionDataTask (#736) Signed-off-by: Dan Cunningham <[email protected]> Co-authored-by: Dan Cunningham <[email protected]> Signed-off-by: Tim Bert <[email protected]>
* Migrate onReceiveSessionTaskChallenge and onReceiveSessionTaskChallenge from closure to function (in the past this allowed reuse code for challenge responses between Kingfisher and Alamofire libraries), simplified their signature as the first two parameters were ignored, avoids useless initializers for URLSession and URLSessionDataTask * Fix for keyWindow deprecation warning --------- Signed-off-by: Dan Cunningham <[email protected]> Co-authored-by: Dan Cunningham <[email protected]> Signed-off-by: Tim Bert <[email protected]>
) Signed-off-by: Tim Bert <[email protected]>
…mpler https://www.swiftbysundell.com/tips/optional-swiftui-views/ Signed-off-by: Tim Müller-Seydlitz <[email protected]> Signed-off-by: Tim Bert <[email protected]>
Signed-off-by: Tim Bert <[email protected]>
Signed-off-by: Tim Bert <[email protected]>
…able from Swift 5.7 Switched from ScrollView to List FrameRow without background Hide .placeholder icon Signed-off-by: Tim Bert <[email protected]>
|
Cool! is this ready for review or are you still working on it? |
|
Am still working on it. The sitemap is hard wired. This should be changed. |
…ot be uicomponents_watch Reverted to previous Endpoint definition /
|
Also considers #722 - allowing to set the sitemap path to, for instance, uicomponents_watch |
This was referenced Nov 16, 2023
Signed-off-by: Tim Bert <[email protected]>
3 tasks
Signed-off-by: Tim Bert <[email protected]>
…atch Signed-off-by: Tim Müller-Seydlitz <[email protected]>
Modified .gitignore
Signed-off-by: Tim Bert <[email protected]>
Migration to #Preview Migration to 2020 API for OSLog
Signed-off-by: Tim Bert <[email protected]>
Signed-off-by: Tim Bert <[email protected]>
Signed-off-by: Dan Cunningham <[email protected]>
…ttings. Signed-off-by: Dan Cunningham <[email protected]>
…p for watch Sync Preferences to sitemap for watch in DrawerView Signed-off-by: Tim Bert <[email protected]>
|
This looks good to me ! I say merge when ready ! |
|
Cool! When can we expect an update in Testflight? |
|
Should not be very long |
|
|
|
We miss some instructions here. Please do the following
|
|
|
|
Let's continue this discussion on #800. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of a build warning that WatchKit storyboards are deprecated as of watchOS 7.0.
Addresses #738 and #748